php - Random number insert mySQL not working -


hey created 2 random numbers so:

 $firstlink = intval(mt_rand(100, 999) . mt_rand(100, 999) . mt_rand(1, 9) . mt_rand(100, 999)); // 10 digit  $secondlink = intval(mt_rand(1000, 999) . mt_rand(1, 999) . mt_rand(10, 99) . mt_rand(100, 999));

and insert code:

$result = mysql_query("insert useraccount                       (category,fname,lname,firstlink,secondlink,accdate)                        values (  '" . $cat . "',                                 '" . $fname . "',                                 '" . $lname . "',                                 " . $firstlink . ",                                 " . $secondlink . ",                                 '" . date('y-m-d g:i:s',time()). "');");

it has no errrs , places data mysql database. however, same number both firstlink , secondlink no matter add database , have no idea why doing it!

the datatype both rows int(15)

you can simplify code , improve randomness of code this:

$firstlink = mt_rand(10000,99999) . mt_rand(10000,99999); $secondlink = mt_rand(10000,99999) . mt_rand(10000,99999);      echo "insert useraccount                       (category,fname,lname,firstlink,secondlink,accdate)                        values (  '" . $cat . "',                                 '" . $fname . "',                                 '" . $lname . "',                                 " . $firstlink . ",                                 " . $secondlink . ",                                 '" . date('y-m-d g:i:s',time()). "');"

phpfiddle: http://phpfiddle.org/main/code/6nf-wpk

this build random 10-digit code making 2 random 5 digit codes , joining them together. is simpler , easier follow less parts making up. had done 2 mt_rand()s because maximum number possible 2147483647. each mt_rand() function you're using, you're preventing 0 being first digit in section of number, because you're starting first digit @ between 1 , 9.

if don't care first number being 1 or 2 (and never being 3-9 or 0) can use 

$firstlink = mt_rand(1000000000,2147483647);  // random 10 digit number $secondlink = mt_rand(1000000000,2147483647); // random 10 digit number

as general coding tips:

  • be consistent how name variables. have lowercase "l" in "$firstlink" , capital "l" in "$secondlink". php case-sensitive , you'll end using wrong name , getting unexpected (blank) results elsewhere in program.
  • be careful never put user-provided data sql command without protecting against sql injection attacks. use parameterized queries rule. see how can prevent sql injection in php? more details , examples.

Comments

Post a Comment

Popular posts from this blog

c# - Send Image in Json : 400 Bad request -

from android trying send image class of data, iis webservice. (c#) the problem 400 bad request . the image being encoded base64 . , placed json rest of class elements. my guess base64 not valid inside json. server not understand it. if set string "" , post accepted fine. so question is, how make base64 valid within json array? ( tried url.encode no success). or how should send image android webservice? gson gson = new gson(); string json = gson.tojson(record); // record has param { string base64photo } how big image? i'm pretty sure surpassing iis json size limit (default 4 mb). check http://geekswithblogs.net/frankw/archive/2008/08/05/how-to-configure-maxjsonlength-in-asp.net-ajax-applications.aspx or http://www.webtrenches.com/post.cfm/iis7-file-upload-size-limits good luck!
Read more

javascript - addthis share facebook and google+ url -

i attempting use addthis create simple url shares whichever current page user on when click share button. of right now, have twitter working. when user clicks, able see url populated in tweet box. when user clicks facebook or google+, url doesn't seem show in share box. <ul class="addthis_toolbox addthis_default_style "> <li><a class="addthis_button_facebook"><img src="/img/facebook-social.png" width="20" height="20" border="0" alt="share" /></a></li> <li><a class="addthis_button_twitter"><img src="/img/twitter-social.png" width="20" height="20" border="0" alt="share" /></a></li> <li><a class="addthis_button_google_plusone_share"><img src="/img/google-social.png" width="20" height="20" border="0" alt="s...
Read more

ios - Show keyboard with UITextField in the input accessory view -

i have buttona , when buttona clicked, want keyboard show uitextfield in inputaccessoryview. there way have keyboard show manually , set inputaccessoryview without having uitextfield initially? thanks. you cannot summon keyboard without object can become first responder. there 2 ways work around: subclass uiview , implement uikeyinput protocol in it. example: in .h file: @interface inputobject : uiview<uikeyinput> @property (nonatomic, copy) nsstring *text; @property (nonatomic, strong) uiview *inputaccessoryview; // must override inputaccessoryview , since it's readonly default @end in .m file, implement protocol: - (bool)canbecomefirstresponder { return yes; } - (bool)hastext { return [self.text length]; } - (void)inserttext:(nsstring *)text { nsstring *selftext = self.text ? self.text : @""; self.text = [selftext stringbyappendingstring:text]; [[nsnotificationcenter defaultcenter] postnotificationname:kinputobjec...
Read more